General sample transmission UI #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgot to update tests for changes made to the results output Refs #11072
|
Jenkins, retest this please. |
|
Dan, this pull request can't be merged, could you merge master into the branch please |
Conflicts: Code/Mantid/Framework/PythonInterface/plugins/algorithms/CalculateSampleTransmission.py Refs #11072
|
It seems that there're conflicts again. |
Conflicts: Code/Mantid/Framework/PythonInterface/plugins/algorithms/CalculateSampleTransmission.py Refs #11072
|
All looks good to me. Very usable interface. Maybe you could add the x and y axes' titles, although that is well documented and on the dialog it would take space, and probably people using this don't need to be reminded what the plot shows. |
FedeMPouzols
added a commit
that referenced
this pull request
Feb 25, 2015
…mission_ui General sample transmission UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket #11072.
To test open the General > Sample Transmission Calculator interface, review its documentation, try it with a range of wavelength ranges and samples.