Modernize event filter gui #23778
Merged
Modernize event filter gui #23778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfpeterson
added
the
GUI
rosswhitfield
requested changes
Oct 12, 2018
There was a problem hiding this comment.
Starting FilterEvents in the workbench with python2 I get
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/matplotlib/backends/backend_qt5agg.py", line 155, in __draw_idle_agg
self.draw()
File "/usr/lib/python2.7/dist-packages/matplotlib/backends/backend_qt5agg.py", line 128, in draw
self.update()
RuntimeError: wrapped C/C++ object of type MplFigureCanvas has been deleted
with python3 I get
Traceback (most recent call last):
File "/home/rwp/mantid/qt/applications/workbench/workbench/app/mainwindow.py", line 291, in <lambda>
action.triggered.connect(lambda checked, script=script: self.launchCustomGUI(script))
File "/home/rwp/mantid/qt/applications/workbench/workbench/app/mainwindow.py", line 254, in launchCustomGUI
execfile(script)
NameError: name 'execfile' is not define
martyngigg
reviewed
Oct 12, 2018
|
|
||
|
|
||
| app = qapp() | ||
| app, within_mantid = get_qapplication() |
|
I'm also seeing an error when trying to start it in MantidPlot: |
|
Nevermind about my bug above. One of the Python modules hadn't rebuilt properly. It's fine in MantidPlot. |
This is a duplicate of the one in mantidqt and should go away.
Replacing lots of things with qtpy and abstracting off the backend running in matplotlib
peterfpeterson
force-pushed
the
modernize_event_filter_gui
branch
from
6fc4c48
to
9a9f397
Compare
…ter_gui Conflicts: scripts/gui_helper.py
rosswhitfield
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main task was to make the gui qt4/qt5 compatible so something could be included in the new workbench.
Part of what was done was to refactor a some associated code into an abstraction of the matplotlib backends to access widgets in
MPLwidgetsand addgui_helper.pyto assist in setting the correct matplotlib backend and launch custom guis with less boilerplate code. They should go inmantidqt, but that isn't available from mantidplot currently.To test:
mantidpython .../scripts/FilterEvents.pyandmantidpython --classic .../scripts/FilterEvents.py.This is associated with #23762.
This does not require release notes because workbench.
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.