Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python API docs for RebinParamsValidator #24605

Merged
merged 1 commit into from Jan 28, 2019

Conversation

soininen
Copy link

Add the missing .rst file and docstring for RebinParamsValidator.

Report to: [nobody].

To test:

Build the all and docs-html targets and check that the documentation for mantid.kernel.RebinParamsValidator appears in the correct place.

There is no associated issue.

This does not require release notes because it is an insignificant addition to the API docs.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

@martyngigg martyngigg merged commit 12bf030 into master Jan 28, 2019
@martyngigg martyngigg deleted the RebinParamsValidator_api_docs branch January 28, 2019 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants