Add simpleapi import to GeneratePythonScript files #24719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'from mantid.simpleapi import *' is added to top of scripts generated by GeneratePythonScript algorithm.
ghost
added
the
GUI
Pasarus
previously requested changes
Feb 7, 2019
| @@ -133,6 +133,7 @@ void GeneratePythonScript::exec() { | |||
| "#Python Script Generated by GeneratePythonScript Algorithm\n"; | |||
| generatedScript += "#########################################################" | |||
| "#############\n"; | |||
| generatedScript += "from mantid.simpleapi import *\n"; | |||
There was a problem hiding this comment.
Would it be better to add an extra \n so that it has a proper separation between the import and the code.
ghost
force-pushed
the
24698_GeneratePythonScript_to_import_simpleapi
branch
from
ceaa8f6
to
9496443
Compare
martyngigg
dismissed
Pasarus’s stale review
The changes requested have been applied but @Pasarus is away for a couple of days so lets not hold this up.
martyngigg
approved these changes
Feb 12, 2019
SimonHeybrock
deleted the
24698_GeneratePythonScript_to_import_simpleapi
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work.
Workbench does not import Mantid's simple API algorithms behind the scenes like MantidPlot, so 'from mantid.simpleapi import *' has been added to the top of scripts generated by the GeneratePythonScript algorithm to make them compatible.
Report to: [nobody].
To test:
Generate a script using the GeneratePythonScript algorithm in workbench and check it includes the import.
Fixes #24698.
This does not require release notes because workbench not yet released
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.