Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy spectra-detector mapping algorithm #249

Merged
merged 10 commits into from Mar 2, 2015
Merged

Copy spectra-detector mapping algorithm #249

merged 10 commits into from Mar 2, 2015

Conversation

DanNixon
Copy link
Member

Fixes #11125.

To test: review documentation, try the algorithm with some actual data based on the usage example.

@DanNixon DanNixon added the Framework Issues and pull requests related to components in the Framework label Feb 19, 2015
@DanNixon DanNixon added this to the Release 3.4 milestone Feb 19, 2015
@raquelalvarezbanos raquelalvarezbanos self-assigned this Feb 20, 2015
@raquelalvarezbanos
Copy link
Contributor

Code and unit test look nice, well documented as well. I have just noticed an issue: when dealing with workspace groups Mantid crashes. This is confusing when you only have one workspace group loaded in Mantid and then you execute the algorithm, as it crashes without information. Given the purpose of the algorithm I may not make much sense trying to use workspace groups, but an error message would be useful.

@DanNixon
Copy link
Member Author

Understandably, it should only be used with matrix workspaces.
Will change the properties to workspace properties instead.

@DanNixon
Copy link
Member Author

Jenkins, retest this please.

@abuts
Copy link
Member

abuts commented Feb 26, 2015

Jenkins, retest this please

@DanNixon
Copy link
Member Author

DanNixon commented Mar 2, 2015

Jenkins, retest this please.

raquelalvarezbanos added a commit that referenced this pull request Mar 2, 2015
@raquelalvarezbanos
Merge pull request #249 from mantidproject/11125_copy_detector_mappin…
ff99c4e 
…g_algorithm

Copy spectra-detector mapping algorithm
@raquelalvarezbanos raquelalvarezbanos merged commit ff99c4e into master Mar 2, 2015
@raquelalvarezbanos raquelalvarezbanos deleted the 11125_copy_detector_mapping_algorithm branch March 2, 2015 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@raquelalvarezbanos raquelalvarezbanos

Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Milestone
Release 3.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanNixon @raquelalvarezbanos @abuts