Handle failure in CreateGroupingWorkspace where group count > spectra count #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanNixon
added
the
Framework
|
The fix is fine and works as expected. I tried a negative number for the |
|
👍 |
martyngigg
added a commit
that referenced
this pull request
Feb 20, 2015
…ace_handle_group_count_failure Handle failure in CreateGroupingWorkspace where group count > spectra count
martyngigg
deleted the
11140_creategroupingworkspace_handle_group_count_failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11140.
To test, review unit test and see that the failure case is now tested, try the original failure case (in the Trac description) with different group numbers with different instruments.