Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for lambda on two mode (no ticket) #26567

Merged
merged 3 commits into from Aug 13, 2019

Conversation

geishm-ansto
Copy link
Collaborator

Description of work.
The previous pelican loader could not handle data captured in lambda on two mode (halves the wavelength), this adds this capability.

To test:
The loader test code has been updated.

Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

@Matthew-Andrew Matthew-Andrew self-assigned this Aug 13, 2019
Copy link
Contributor

@Matthew-Andrew Matthew-Andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and has appropriate tests, also worked for me locally.

@martyngigg martyngigg added this to the Release 4.2 S1 milestone Aug 13, 2019
@martyngigg martyngigg merged commit c866159 into mantidproject:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants