Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New algorithm to bin HFIR powder diffractometer data from MDEventWorkspaces #285

Merged
merged 23 commits into from Mar 5, 2015

Conversation

wdzhou
Copy link
Collaborator

@wdzhou wdzhou commented Feb 23, 2015

Fixes issues #10929

A new algorithm ConvertCWPDMDToSpectra is simplemented in order to convert a set of reactor-sourced powder diffraction data in MDWorkspaces to a single spectrum matrix by binning the data according to 2theta value of the detectors.

By adding .h, .cpp, Test.h and .rst file. And modified CMakeLists.

*	modified:   MDAlgorithms/CMakeLists.txt
*       new file:   MDAlgorithms/inc/MantidMDAlgorithms/ConvertCWPDMDToSpectra.h
*	new file:   MDAlgorithms/src/ConvertCWPDMDToSpectra.cpp
*	new file:   MDAlgorithms/test/ConvertCWPDMDToSpectraTest.h
*	new file:   ../docs/source/algorithms/ConvertCWPDMDToSpectra-v1.rst
- modified:   ../Mantid/Framework/MDAlgorithms/src/ConvertCWPDMDToSpectra.cpp  : tried fix some problem of linear interpolation (not finished yet)
- modified:   ../Mantid/Framework/MDAlgorithms/src/ConvertSpiceDataToRealSpace.cpp  : fixed an issue as no run start is given
@wdzhou wdzhou changed the title Fixes issue [#10929](http://mantidproject.org/mantid/ticket/10929) Fixes issue [#10929] Feb 23, 2015
@wdzhou wdzhou changed the title Fixes issue [#10929] About issue [#10929] Feb 23, 2015
@eXeC64 eXeC64 added this to the Release 3.4 milestone Feb 24, 2015
1. Fix the label for Y value: Intensity
2. Fix the doxygen warning
3. Fix cppcheck
4. Fixes the standard error issue in ConvertSpiceToRealSpace
5. Add 'start_time' to LoadSpiceAscii, ConvertSpiceToRealSpace and ConvertCWPDMDToSpectra
@martyngigg
Copy link
Member

Please can you give a better title to the pull request. It shouldn't have the ticket reference in it and should be a short sentence describing the changes - something like "New algorithm to convert reactor-based powder data to spectrum matrix" would be fine.

@wdzhou wdzhou changed the title About issue [#10929] New algorithm to bin HFIR powder diffractometer data from MDEventWorkspaces Feb 25, 2015
@wdzhou wdzhou added the Powder Issues and pull requests related to powder diffraction label Mar 3, 2015
@wdzhou wdzhou removed the In Progress label Mar 3, 2015
@wdzhou
Copy link
Collaborator Author

wdzhou commented Mar 3, 2015

== For tester ==

A new algorithm CovertCWPDMDToSpectra is implemented in this algorithm in order to convert the data MDEventWorkspace and monitor MDEventWorkspace to a single spectra histogram for HFIR powder diffractometers.

Tester should check that all the tests are passed and whether the documentation is clear.

The files for verifying this pull request can be found at [https://gist.github.com/wdzhou/0bccce66d7c322153e54]
There are three data files and two python script. One script just loads and reduces one Spice data file. The other loads three data files, merges them and reduces. You may compare the reduced data from single Spice file and the merged.

AndreiSavici added a commit that referenced this pull request Mar 5, 2015
New algorithm to bin HFIR powder diffractometer data from MDEventWorkspaces
@AndreiSavici AndreiSavici merged commit a8ad2e4 into master Mar 5, 2015
@AndreiSavici AndreiSavici deleted the feature/10929_reduce_hb2a branch March 5, 2015 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Powder Issues and pull requests related to powder diffraction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants