Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDEstimateDetectorResolution improvements #320

Merged
merged 13 commits into from Mar 3, 2015

Conversation

peterfpeterson
Copy link
Member

This was originally trac #11182.

To test: Make sure that the new functionality from the ticket is in place.

  • It validates the input parameters on exec rather than in init
  • It should be mentioned in CalibrateRectangularDetectors and GetDetOffsetMultiPeaks as well as link to them
  • Make it work with a "metadata only" workspace
  • Allow the user to supply the cetre wavelength

Special Note: This does introduce a small change to LoadEventNexus so doing some testing of unrelated functionality that requires event nexus files is a good idea.

Since the workspace has it, just use its.
@peterfpeterson peterfpeterson added Diffraction Issues and pull requests related to diffraction and removed In Progress labels Feb 27, 2015
@wdzhou wdzhou self-assigned this Feb 27, 2015
@peterfpeterson
Copy link
Member Author

It looks like I broke the usage test.

@wdzhou
Copy link
Collaborator

wdzhou commented Mar 3, 2015

The new features work fine. The ticket is to be closed.

But the documentation of LoadEventNexus should be modified because the behavior of loading meta data only is changed, i.e., the number of spectra in output workspace is change.

wdzhou added a commit that referenced this pull request Mar 3, 2015
…solution_improvements

PDEstimateDetectorResolution improvements
@wdzhou wdzhou merged commit ad3fa44 into master Mar 3, 2015
@wdzhou wdzhou deleted the 11182_EstimatePDDeterminResolution_improvements branch March 3, 2015 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants