New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDEstimateDetectorResolution improvements #320
Merged
wdzhou
merged 13 commits into
master
from
11182_EstimatePDDeterminResolution_improvements
Mar 3, 2015
Merged
PDEstimateDetectorResolution improvements #320
wdzhou
merged 13 commits into
master
from
11182_EstimatePDDeterminResolution_improvements
Mar 3, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't adding spectra to the workspace.
Since the workspace has it, just use its.
peterfpeterson
added
Diffraction
Issues and pull requests related to diffraction
and removed
In Progress
labels
Feb 27, 2015
It looks like I broke the usage test. |
…erminResolution_improvements
…erminResolution_improvements
The new features work fine. The ticket is to be closed. But the documentation of LoadEventNexus should be modified because the behavior of loading meta data only is changed, i.e., the number of spectra in output workspace is change. |
wdzhou
added a commit
that referenced
this pull request
Mar 3, 2015
…solution_improvements PDEstimateDetectorResolution improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally trac #11182.
To test: Make sure that the new functionality from the ticket is in place.
CalibrateRectangularDetectors
andGetDetOffsetMultiPeaks
as well as link to themSpecial Note: This does introduce a small change to
LoadEventNexus
so doing some testing of unrelated functionality that requires event nexus files is a good idea.