Impove documentation for ExportSampleLogsToCSVFile #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On branch feature/10891_ExportSampleLogs_Doc - modified: ExportSampleLogsToCSVFile-v1.rst
|
The documentation is more specific now, explaining the what and how. I've never used this algorithm but I'd know how to use it from this extended description. I only have a comment (see the comment inline). Please let me know what you think, and I'll merge the changes in. |
|
|
||
| - Column 0: Absolute time in second |
There was a problem hiding this comment.
This "Absolute time in second" is with respect to something like the Unix epoch, the experiment start time, a certain reference date/time or what exactly?
Also, second -> seconds?
There was a problem hiding this comment.
The absolute time is with respect to unix epoch. I've made the change to make it clear in the doc. Thanks.
FedeMPouzols
added a commit
that referenced
this pull request
Mar 4, 2015
…Logs_Doc Impove documentation for ExportSampleLogsToCSVFile
FedeMPouzols
added
the
Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was original trac ticket #10891.
The documentation of algorithm ExportSampleLogsToCSVFile has been improved, especially about property TimeZone.