New algorithm to load SPICE XML data #365
Conversation
On branch feature/11098_hb3a_2ddata - modified: ../../../Framework/DataHandling/CMakeLists.txt - new file: ../../../Framework/DataHandling/inc/MantidDataHandling/LoadSpiceXML2DDet.h - new file: ../../../Framework/DataHandling/src/LoadSpiceXML2DDet.cpp - new file: ../../../Framework/DataHandling/test/LoadSpiceXML2DDetTest.h - new file: HB3A_exp355_scan0001_0522.xml.md5
wdzhou
added
In Progress
Diffraction
And cleaned the debugging output as well.
|
retest please. |
|
Please |
|
test this please |
|
For tester: A new algorithm LoadSpiceXML2DDet is implemented in this algorithm. In order to test, you can download any XML files of HFIR's HB3A from http://neutron.ornl.gov/user_data/hb3a/exp355/Datafiles/. You may run the algorithm to load data and check the output MatrixWorkspace including the spectra and sample logs. |
|
retest please. |
|
retest this please |
|
Jekins, test this please. |
|
Jenkins, retest this please |
| /** Parse SPICE XML file for one Pt./measurement | ||
| * @brief LoadSpiceXML2DDet::parseSpiceXML | ||
| * @param xmlfilename | ||
| * @param logstringmap |
There was a problem hiding this comment.
I think logstringmap should be vecspicenode?
There was a problem hiding this comment.
Yes, you are right on this. I forgot to update the parameter's name after I changed the input from map to vector. It has been corrected.
|
Code looks very good and it comes with a unit test and doc tests. I think it's ready to be merged in. I only spotted a very minor issue with a doxygen tag (see inline comment above). Please have a look at it, and I'll merge this PR. I'd also suggest adding a short description of the parameters if there's any point that needs to be clarified (like expected format, typical usage, etc.). WZ: I added some descriptions to function parameters. |
|
Just another comment. I tested the algorithm with a few example XML files from the link that you posted above. Everything seems to work well. Maybe in the future a default value for the 'DetectorGeometry' could be guessed from the file? For interactive use it would be convenient, although I'm not sure if this algorithm will be used directly, or just as part of the HFIR HB3A load/reduce workflow. WZ: This algorithm is not likely to be used in interactive mode, because for one typical HB3A experiment, there will be tens or hundreds of this file. There will be a workflow algorithm to read and reduce the data to Q-space in the end. So far, only HB3A is the only one that uses 2D detector among all HFIR's diffraction and inelastic instruments. |
|
Oh and another comment, could you add the ticket number for this? WZ: the original ticket number is #11098. Thanks for testing my ticket. |
|
We got a glitch on the win7 build, so I stopped the builds that were still running. Let's try again... |
|
Jenkins, retest this please |
1 similar comment
|
Jenkins, retest this please |
New algorithm to load SPICE XML data
SPICE records 2D anger camera's data in XML format. The new algorithm is designed to read this type of XML file and create a MatrixWorkspace for it.