Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LET modifications for cycle 2015/1 #369

Merged
merged 5 commits into from Mar 11, 2015
Merged

LET modifications for cycle 2015/1 #369

merged 5 commits into from Mar 11, 2015

Conversation

abuts
Copy link
Member

@abuts abuts commented Mar 9, 2015

@abuts
Copy link
Member Author

abuts commented Mar 9, 2015

These are trivial changes, reflecting changes in LET configuration for cycle 2015/1 (or rather 2014/03)
They can be safely merged as soon as system test which verifies IDF correctness passes,

@AndreiSavici
Copy link
Member

Is ISIS_LETReduction.py supposed to be a systemtest? Then why have hardcoded paths to c or d drives? If not, why is it in systemtests?

@peterfpeterson peterfpeterson added this to the Release 3.4 milestone Mar 9, 2015
@FedeMPouzols FedeMPouzols added the Framework Issues and pull requests related to components in the Framework label Mar 10, 2015
@abuts
Copy link
Member Author

abuts commented Mar 10, 2015

ISIS_LETREduction.py is a sample of reduction run. It is also part of the system test ISISDirectInelastic. This test instantiates classes from ISISLETReduction (and number of other files for different instruments) with its own path-es and settings and runs them as a system test.

As sample reduction run it runs from Mantid and user expected to change harcorded path to the one suitable for his machine.

@abuts
Copy link
Member Author

abuts commented Mar 10, 2015

While the commit have not been closed, I use this opportunity to fix minor bug, identified while running reduction from web services.

@abuts
Re #11292 Merge branch 'master' into 11292_LET_cycle2015_1_changes
4834942 
Conflicts:
	Code/Mantid/Testing/SystemTests/tests/analysis/ISIS_LETReduction.py
	Code/Mantid/scripts/Inelastic/Direct/DirectEnergyConversion.py
@Anders-Markvardsen Anders-Markvardsen self-assigned this Mar 11, 2015
Anders-Markvardsen added a commit that referenced this pull request Mar 11, 2015
@Anders-Markvardsen
Merge pull request #369 from mantidproject/11292_LET_cycle2015_1_changes
1034da6 
LET modifications for cycle 2015/1
@Anders-Markvardsen Anders-Markvardsen merged commit 1034da6 into master Mar 11, 2015
@Anders-Markvardsen Anders-Markvardsen deleted the 11292_LET_cycle2015_1_changes branch March 11, 2015 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Anders-Markvardsen Anders-Markvardsen

Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Milestone
Release 3.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@abuts @AndreiSavici @peterfpeterson @Anders-Markvardsen @FedeMPouzols