-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TeixeiraWaterIqt to IqtFit #37189
Add TeixeiraWaterIqt to IqtFit #37189
Conversation
7e4623c
to
7905500
Compare
7905500
to
214f363
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing the Teixeira water on IqtFit. I have tested it and it is easy to make fix now from the tab.
But even if the fit is successful, it is not very good. I have found that compositing with a LinearBackground
function improves a lot the Teixeira fitting. I think the linear background fitting function would be a good addition to the background fitting functions on this property browser (I know it can be done with the full function browser, but it would be better to have it in the simple function menu). But that can be done on a separate issue if you agree.
qt/scientific_interfaces/Inelastic/QENSFitting/FunctionBrowser/FitTypes.cpp
Show resolved
Hide resolved
Thanks for the suggestion, I think it would be good to check with Spencer, and then done as part of a separate issue if he agrees |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments. I'm happy to approve, it is a nice addition to IqtFit Tab.
@robertapplin @adriazalvarez The IqtFit gui already has the Flatbackground option. You can then Tie intensities s\o that they sum to 1. |
Description of work
This PR adds the
TeixeiraWaterIqt
fit function to the IqtFit tab of the inelastic QENS Fitting interface. It makes sure that the q values for the fit function are updated when changing the plotted spectrum.Fixes #36502
To test:
TeixeiraWaterIqt
option in Fit TypeReviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.