Pin jemalloc to v5.2.0 for install package #37405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not included in the package dependencies. This also sorts the dependencies so diff shows more meaningful information when comparing the platforms.
v5.2.1 has an issue for some tests, v5.3.0 doesn't want to work on rhel9
peterfpeterson
added
the
Bug
|
Can we point this at |
|
Linux package build 1860 is resubmitted against |
thomashampson
requested changes
May 22, 2024
Co-authored-by: thomashampson <thomas.hampson@stfc.ac.uk>
thomashampson
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
mantidpackage installer match the version of jemalloc that the developers are using.Refs #36220 .
Further detail of work
The main change is to pin the version of jemalloc for the package to v5.2.0. It is unclear what is wrong with the newer versions, but comparing the recipe from v5.2.0 and recipe from v5.3.0 one will immediately discover that v5.3.0 reworked the packages so there is now a
jemallocpackagelibjemallocpackage where v5.2.0 only hasjemallocpackage. More investigation will need to be done to figure out how to move forward from v5.2.0.The oddity is that both v5.2.0 and v5.3.0 work on rhel7, but only v5.2.0 works on rocky8 and rhel9.
There is some extra cleanup of the developer dependencies so they can more easily be compared using
diff(sorting), removing duplicate dependencies (conda-wrapperstwice in windows), removing unused osx dependency (jemallocis not runtime for mac).Bonus information: The abi compatibility chart for jemalloc doesn't go all the way to v5.3.0.
To test:
Install the built linux package on newer rhel and see that it can start and show the instrument view with opengl.
This does not require release notes because it is fixing a bug within the release cycle discovered when moving from rhel7.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.