Fix memory, initialization and other coverity issues in Framework (especially Load* classes) #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedeMPouzols
added
Coverity
Framework
FedeMPouzols
added
the
Maintenance
| @@ -115,16 +115,16 @@ class DLLExport LoadMask : public API::Algorithm { | |||
| std::vector<int> &rangeendvec); | |||
|
|
|||
| /// Mask Workspace | |||
| DataObjects::MaskWorkspace_sptr mMaskWS; | |||
| DataObjects::MaskWorkspace_sptr m_MaskWS; | |||
There was a problem hiding this comment.
I suspect when you renamed this, you didn't mean to capitalise the M :)
Same goes for m_DefaultToUse.
There was a problem hiding this comment.
Good that you caught this. I'm fixing it...
|
Other than that it looks good. Nice big clean up for Coverity 👍 |
eXeC64
added a commit
that referenced
this pull request
Mar 16, 2015
…_issues_framework_load_classes Fix memory, initialization and other coverity issues in Framework (especially Load* classes)
eXeC64
deleted the
11328_fix_various_coverity_issues_framework_load_classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes ~30 issues listed in ticket #11328.
I tried to get rid of most if not all remaining issues in the Load* classes, excluding security issues and a handful of unclear ones.
Tester: code review, check that all tests are ok, which cover quite decently most of the changes included here.