New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Changes From Rob and Richard for ISIS SANS #393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The files have moved on from the version of the code used by Rob, so this required some work to bring in the changes. System tests are passing so I think we're okay here. Refs #11360.
The new params just needed defaults.
It looks like RotateInstrumentComponent does actually rotate even if the angle is 0.0. Just dont call it in this case. Should fix remaining system tests.
PeterParker
added
High Priority
An issue or pull request that if not addressed is severe enough to postponse a release.
SANS
Issues and pull requests related to SANS
In Progress
labels
Mar 15, 2015
Win7 build failed with the following:
Which looks very much like an intermittent problem with the builder rather than an issue with the changes made as part of this ticket. |
Jenkins, retest this please |
1 similar comment
Jenkins, retest this please |
Sophos is complaining about unistall.exe again for some reason. It's possible that it's quite flaky about changes to XML files, and the only XML file that we changed in this branch was the LARMOR param file. Making a trivial change to a comment to try and motivate a different result.
…ntidproject/mantid into 11360_merge_robs_larmor_changes
These changes didn't have the desired effect. For now, making sure that the Win7 build happens on the machine with on-access virus scanning turned off, so at least we have something to give to Richard and Rob.
Jenkins, retest this please. |
This failed again, but now because of RHEL 6 being flaky!. Pushed a revert of the last two commits to set off yet another build. |
Anders-Markvardsen
added a commit
that referenced
this pull request
Apr 1, 2015
…anges Merge Changes From Rob and Richard for ISIS SANS
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
High Priority
An issue or pull request that if not addressed is severe enough to postponse a release.
SANS
Issues and pull requests related to SANS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes trac issue #11360.
To tester
These are changes given to us by Rob Dalgliesh and Richard Heenan, which I'm merging for them almost completely "as is". I have:
I am submitting this pull request so that I may provide them both with a build which they can use to give the changes a final "once-over" before the cycle starts this week.
For testing purposes, I'd recommend waiting until we hear back from the scientists that the changes are working as they intended, then simply do a code review.
Rob has said that he would like to provide us with system test data / reduction scripts so that we may have LARMOR covered with adequate test coverage. Having said that, they are very keen on getting something they can use into the nightly builds ASAP, so we will have to do this in a separate ticket at a later date.