Add IRemoteJobManager interface #398
Conversation
FedeMPouzols
added
the
Framework
|
Jenkins, retest this please |
1 similar comment
|
Jenkins, retest this please |
|
Jenkins, retest this please |
1 similar comment
|
Jenkins, retest this please |
FedeMPouzols
changed the title
| * properly. | ||
| * @throws std::runtime_error If authentication fails | ||
| */ | ||
| virtual void authenticate(std::string &username, std::string &password) = 0; |
There was a problem hiding this comment.
Is there a good reason that the parameters are non-const references when all other methods in the interface accept a const reference to a string?
There was a problem hiding this comment.
Ups, I'll fix it, there's definitely no reason.
|
Most of our interface classes are in API, is there a reason this is in Kernel? |
|
I guess that I just put it in the same place where the current RemoteJobManager class lives. |
|
Kernel/API are a somewhat arbitrary split so I just wondered on the reason. Thanks |
|
Jenkins, retest this please |
1 similar comment
|
Jenkins, retest this please |
|
Seemingly unrelated and random system test failue.. Jenkins, retest this please |
|
Jenkins, retest this please |
1 similar comment
|
Jenkins, retest this please |
|
Jenkins could you retest this please? |
|
Jenkins, retest this please |
4 similar comments
|
Jenkins, retest this please |
|
Jenkins, retest this please |
|
Jenkins, retest this please |
|
Jenkins, retest this please |
| std::string startDate; | ||
| /// Date-time the job finished. No particular format can be | ||
| /// assumed | ||
| std::string completionTime; |
There was a problem hiding this comment.
Shouldn't the time-related have a more appropriate type (DateAndType for example)?
There was a problem hiding this comment.
Good point, I'm going to change the type of those three to DateAndTime.
The schedulers that we have in practice (LSF and Mantid API/MOAB) use different formats but both can be converted to DateAndTime.
|
Jenkins, retest this please |
3 similar comments
|
Jenkins, retest this please |
|
Jenkins, retest this please |
|
Jenkins, retest this please |
|
Jenkins... retest this please |
Add IRemoteJobManager interface
This addresses ticket #11123 and it is an intermediate step in a chain of tickets towards generic remote algorithms. This just adds an interface. It will become more testable when the RemoteJobManager factory and the specialized job managers are added in follow-up PRs.
To test: this PR just adds an interface. See the ticket for details on the "remote job manager" design. Check that it is well documented and that the documentation reads well. As this goes in principle in Framework/Kernel, it would be great if an experienced Mantid developer double checks that everything is fine and follows the rules/conventions/style.