Find HDF5 headers in exotic locations #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 This is a sensible change and we might need debian in the not too distant future for the ESS so it is good to get things fixed! |
martyngigg
added a commit
that referenced
this pull request
Mar 20, 2015
…_exotic_places Find HDF5 headers in exotic locations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11388.
Note that
OSX_VERSION VERSION_LESS 10.9is evaluated as true whenOSX_VERSIONis not defined. HDF5 include paths were effectively not being added, but this easily remains unnoticed, as in most systems all the headers are shipped in standard/system include directories.Tester: this just has the effect that rare include paths are found for hdf5, if needed (debian as far as I know). Double checking that it builds on all platforms should be sufficient.