Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bugs and enhancements in Direct inelastic reuction #433

Merged
merged 11 commits into from Mar 23, 2015

Conversation

abuts
Copy link
Member

@abuts abuts commented Mar 19, 2015

This addresses issues mentioned in http://trac.mantidproject.org/mantid/ticket/11397

when sctipt has been stopped in the middle of the calculations and started again. It is not to fail on printing diagnostics results.
Surprisingly it has been working before.
A load mask gets fully defined IDF to avoid problems with fining this file from instrument name.
for case when script stopped by user and then restarted.
@abuts abuts added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Python Direct Inelastic Issues and pull requests related to direct inelastic labels Mar 19, 2015
@abuts
Copy link
Member Author

abuts commented Mar 20, 2015

it is certainly the failure not related to the ticket. But...

@abuts
Copy link
Member Author

abuts commented Mar 20, 2015

Jenkins, retest this please

@abuts abuts removed the In Progress label Mar 20, 2015
@abuts
Copy link
Member Author

abuts commented Mar 20, 2015

java errors are irrelevant

@abuts
Copy link
Member Author

abuts commented Mar 20, 2015

Jenkins, retest this please

@abuts
Copy link
Member Author

abuts commented Mar 20, 2015

now it is something with the data

@abuts
Copy link
Member Author

abuts commented Mar 20, 2015

Jenkins, retest this please

@abuts
Copy link
Member Author

abuts commented Mar 22, 2015

Something strange happening with this build. It looks finished on Jenkins and all builds finished but it is shown as running here (for 48hrs).

@abuts
Copy link
Member Author

abuts commented Mar 22, 2015

Jenkins, retest this please

@abuts abuts added this to the Release 3.4 milestone Mar 23, 2015
@FedeMPouzols FedeMPouzols self-assigned this Mar 23, 2015
@FedeMPouzols
Copy link
Contributor

All looks fine. I also run all the ISIS system tests locally and there were no issues.

FedeMPouzols added a commit that referenced this pull request Mar 23, 2015
Minor bugs and enhancements in Direct inelastic reuction
@FedeMPouzols FedeMPouzols merged commit 585985f into master Mar 23, 2015
@FedeMPouzols FedeMPouzols deleted the 11397_BugsInDirectInelastic branch March 23, 2015 08:40
@FedeMPouzols
Copy link
Contributor

Related to this, the option to FileFinder to skip directories has just been merged: #435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Direct Inelastic Issues and pull requests related to direct inelastic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants