Fix race condition when using ParameterMap #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If threads are competing to try and both check and update the map then they will hit the appropriate PARALLEL_CRITICAL sections within the relevant methods. The bug was that the critical sections all had different names and so OpenMP would not block on an ::add while a ::get is being performed. The critical secctions are renamed to reflect the what they are protecting. Refs #10375
peterfpeterson
added a commit
that referenced
this pull request
Oct 16, 2014
…race_condition Looks good and everything appears to work. I couldn't find where m_mapAccess was defined though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #10375
Test will have to be a code review and confirmation that the system tests are now passing.