Feature/10330 threadpool working with clang #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
test this please |
peterfpeterson
force-pushed
the
master
branch
from
ae43f3d
to
c7be7f6
Compare
|
test this please |
|
The things that have both
|
|
test this please |
|
test this please |
peterfpeterson
deleted the
feature/10330_threadpool_working_with_clang
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang lacks openmp and currently runs everything serially. The ThreadPool class only depends minimally on openmp (determining the number of processors and managing logging from individual threads) and therefore is easy to get working with clang. I also replaced PARALLEL_CRITICAL macros in LoadEventNexus and EventWorkspace with mutexes that will behave the same with and without openmp.
testing: code review double-checking there aren't other algorithms where using the threadpool without openmp might create a race condition. Verify that tests still pass, including those currently disabled in ThreadPoolTest.h.
http://trac.mantidproject.org/mantid/ticket/10330