Fix Create1DWorkspaceConstant #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelWedel
added
the
Framework
PolarizationCorrectionTest failed, because the error on the output workspace of the algorithm is 2.2e-16 instead of 0.0. I could not find out why, so I added a small tolerance to the unit test.
DanNixon
added a commit
that referenced
this pull request
Mar 27, 2015
…ace_constant Fix Create1DWorkspaceConstant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11174.
Testing information
Code review should be enough, it was just a typo in the code. I had to add a tolerance of 3e-16 to CheckWorkspaces in
AlgorithmsTest.PolarizationCorrectionTest.test_run_PA_unityto make it pass. I'm not entirely sure what causes it, my best guess is that during the various operations for creating the output workspace some floating point error accumulates.Before these changes this did not show up because the error in Create1DWorkspaceConst was not initialized so it was 0.