Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDA Absorption Corrections tab #476

Merged
merged 19 commits into from Apr 2, 2015
Merged

IDA Absorption Corrections tab #476

merged 19 commits into from Apr 2, 2015

Conversation

DanNixon
Copy link
Member

Fixes #10903.

To test:

  • Review documentation
  • Open Indirect Data Analysis > Absorption Corrections
  • Try a couple of calculations for each geometry (usage examples for algorithms have suitable sample/can dimensions)

Sample is: irs26176_graphite002_red.nxs
Can is: irs26173_graphite002_red.nxs

@DanNixon DanNixon added Inelastic Indirect/Inelastic Issues and pull requests related to indirect or inelastic labels Mar 27, 2015
@DanNixon DanNixon added this to the Release 3.4 milestone Mar 27, 2015
@FedeMPouzols FedeMPouzols self-assigned this Apr 2, 2015
@FedeMPouzols
Copy link
Contributor

All looks good to me. The documentation is clear and goes to the point. I'd perfectly know how to use this interface even though I have no clue of the theory and calculations behind. I tried the 3 geometries and it seems to be lousy-user-proof. Strange values (0, etc.) are handled with informative errrors.

Maybe the only detail that was not obvious/explicit to me at first is that when you enable 'Save Result' the files are named exactly as the workspaces, simply appending .nxs, like irs26176_graphite002_FlatPlate_Corrected.nxs. There could be a note about this in the description of "Save Result", but that can always be added later.

FedeMPouzols added a commit that referenced this pull request Apr 2, 2015
@FedeMPouzols FedeMPouzols merged commit 5f40c07 into master Apr 2, 2015
@FedeMPouzols FedeMPouzols deleted the 10903_ida_abs_corr_tab branch April 2, 2015 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants