Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaks in ComputeResourceInfo (XML parsing and test) #508

Merged
merged 5 commits into from Apr 2, 2015

Conversation

FedeMPouzols
Copy link
Contributor

This fixes #11467, memory leaks that valgrid detected.

To test:

  • double check that tests passed
  • code review

@FedeMPouzols FedeMPouzols added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework labels Apr 1, 2015
@FedeMPouzols FedeMPouzols added this to the Release 3.4 milestone Apr 1, 2015
@FedeMPouzols
Copy link
Contributor Author

In the last build everything went fine, except that SystemTests.CodeConventions complains about an unrelated algorithm. So despite the red cross I'd say this is ready for testing.

@FedeMPouzols
Copy link
Contributor Author

Jenkins, retest this please

@FedeMPouzols
Copy link
Contributor Author

Jenkins, wake up and retest this please

@stuartcampbell
Copy link
Collaborator

@FedeMPouzols I presume you haven't seen @rosswhitfield comments on slack - the old plugin is now disabled so the retest this type comments won't work anymore. You can either restart the job on jenkins directly or they will trigger with any new code changes.

@FedeMPouzols
Copy link
Contributor Author

Jenkins, retest this please

@peterfpeterson
Copy link
Member

I merged master back into the branch to kick off a new round of builds

@FedeMPouzols
Copy link
Contributor Author

Good, thanks! One of them was definitely stuck since yesterday.

@eXeC64 eXeC64 self-assigned this Apr 2, 2015
@eXeC64
Copy link
Contributor

eXeC64 commented Apr 2, 2015

The only change has been to the ComputeResourceInfo unit test, which has no passed on all platforms. I'm not going to bother to wait for RHEL7 or Windows to finish as any failures that occur can only be random and unrelated.

Reviewed the code and it looks good to me.

eXeC64 added a commit that referenced this pull request Apr 2, 2015
…ResourInfo_XML_parsing

Fix leaks in ComputeResourceInfo (XML parsing and test)
@eXeC64 eXeC64 merged commit 5641750 into master Apr 2, 2015
@eXeC64 eXeC64 deleted the 11467_fix_leaks_in_ComputeResourInfo_XML_parsing branch April 2, 2015 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants