Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make createWorkspace fail noisily #514

Merged
merged 1 commit into from Apr 2, 2015

Conversation

eXeC64
Copy link
Contributor

@eXeC64 eXeC64 commented Apr 2, 2015

This is for trac ticket #11474

Testing: The following script reproduces the issue. If you look at out_md's history, the Projection property is not set. With the changes applied, it fails and provides instructions on how to correct it.

to_cut = CreateMDWorkspace(Dimensions=4, Extents=[-1,1,-1,1,-1,1,-10,10], Names="H,K,L,E", Units="U,U,U,V")
FakeMDEventData(InputWorkspace='to_cut', PeakParams=[10000,-0.5,0,0,0,0.1])
FakeMDEventData(InputWorkspace='to_cut', PeakParams=[10000,0.5,0,0,0,0.1])
SetUB(Workspace=to_cut, a=1, b=1, c=1, alpha=90, beta=90, gamma=90)
SetSpecialCoordinates(InputWorkspace=to_cut, SpecialCoordinates='HKL')

p = Projection([1,1,0], [-1,1,0])

out_md = CutMD(to_cut, Projection=p.createWorkspace(), PBins=([0.1], [0.1], [0.1], [-5,5]), NoPix=True)

@eXeC64 eXeC64 added Python Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework labels Apr 2, 2015
@eXeC64 eXeC64 added this to the Release 3.4 milestone Apr 2, 2015
@OwenArnold OwenArnold self-assigned this Apr 2, 2015
OwenArnold added a commit that referenced this pull request Apr 2, 2015
…_fail_noisily

Make createWorkspace fail noisily
@OwenArnold OwenArnold merged commit 233d871 into master Apr 2, 2015
@OwenArnold OwenArnold deleted the 11474_make_createWorkspace_fail_noisily branch April 2, 2015 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants