Fix LoadISISNexus & LoadMonitors='separate' for multi-period data #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martyngigg
added
High Priority
|
When loading monitors separately, the monitor workspace for the first period looks correct (only 3 spectra, all are monitors) however all other periods seem to have monitors and detectors. |
|
That's not good! I'll take a look. |
The workspace factory as being passed the wrong workspace to clone from. Refs #11486
DanNixon
added a commit
that referenced
this pull request
Apr 8, 2015
…riod_monitors_isis_nexus Fix LoadISISNexus & LoadMonitors='separate' for multi-period data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes trac issue #11486
Tester
OFFSPEC00033772.nxs at ISIS is a multi-period histogram file. Use this to check the loading through both
Loadand more directly throughLoadISISNexus. Check that each of theLoadMonitorsoptions does what you expect and compare the output with loading the corresponding raw file throughLoadRaw