-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/10385 loadnexus speed #56
Commits on Oct 23, 2014
-
refs #10385. Extract spectrum info to object.
This is the first step towards reusing the same spectrum information rather than fetching it renewed each time. One caveat with this is that you will HAVE to be sure that all workspaces in the group are equivalent in terms of instrument detector mappings etc. What i intend to do next is: 1) For workspaces that look to relate to multiperiod group workspaces, default to reuse the spectrum-detectector mappings, once obtained on a lazy basis. 2) Put a boolean property with value in place (which defaults to true) called "PredictiveInstrumentLoading". If false, we would go back to old behaviour.
Configuration menu - View commit details
-
Copy full SHA for 1978e14 - Browse repository at this point
Copy the full SHA 1978e14View commit details -
refs #10385. Naming issue root problem.
There is a naming issue here, which is actually the root cause of the problem! The query that was being performed retrieved the number of workspace entries, NOT the number of periods. Going forward. If the number of periods exactly matches the number of workspace entries, we have a multiperiod group workspace, and can happily apply the optimisations we want. Next step will be to actually extract the nperiods. To do that we need to try to fetch it out of the logs for The first entry.
Configuration menu - View commit details
-
Copy full SHA for fdf6281 - Browse repository at this point
Copy the full SHA fdf6281View commit details -
Configuration menu - View commit details
-
Copy full SHA for d0ba5d5 - Browse repository at this point
Copy the full SHA d0ba5d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a0c599 - Browse repository at this point
Copy the full SHA 8a0c599View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61959e5 - Browse repository at this point
Copy the full SHA 61959e5View commit details
Commits on Oct 29, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 9a67731 - Browse repository at this point
Copy the full SHA 9a67731View commit details -
refs #10385. Test file is twice as fast now.
There are lots of TODOs still to resolve. We also need to add tests for this sort of multiperiod loading.
Configuration menu - View commit details
-
Copy full SHA for ccc1c23 - Browse repository at this point
Copy the full SHA ccc1c23View commit details -
refs #10385. Add failing test.
We are not currently handling log extraction properly, which is why the test is failing. File size is just over the threshold, but shouldn't be a problem. I've tried to trim it down as much as possible.
Configuration menu - View commit details
-
Copy full SHA for 757b004 - Browse repository at this point
Copy the full SHA 757b004View commit details
Commits on Oct 30, 2014
-
refs #10385. Remove log values
This fixes the regression test. We clear the logs off the temporary workspace, that way we don't have to do a similar thing in the loop, and we avoid copying them over each time. This is not a fully formed solution, but it's a start.
Configuration menu - View commit details
-
Copy full SHA for ab1da07 - Browse repository at this point
Copy the full SHA ab1da07View commit details
Commits on Oct 31, 2014
-
refs #10385. Reporting added and extra property.
Also better robustness around workspace type.
Configuration menu - View commit details
-
Copy full SHA for 8e03062 - Browse repository at this point
Copy the full SHA 8e03062View commit details -
refs #10385 Refactor new functionality to method.
Should read better now, although the entire algorithm is still a mess.
Configuration menu - View commit details
-
Copy full SHA for aba603d - Browse repository at this point
Copy the full SHA aba603dView commit details -
refs #10385. Remove instrument info caching
This does result in a speed up, but the caching is being bypassed at the moment since our strategy is to clone and overwrite. I've removed the caching code as part of the clean up, but I've kept the SpecInfo type around as it makes the usage clearer, and does not result in a performance penalty.
Configuration menu - View commit details
-
Copy full SHA for d88bbe4 - Browse repository at this point
Copy the full SHA d88bbe4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b18d28 - Browse repository at this point
Copy the full SHA 5b18d28View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb70f73 - Browse repository at this point
Copy the full SHA fb70f73View commit details -
Extend tests. Do not process spectrum lists.
Configuration menu - View commit details
-
Copy full SHA for ce10e43 - Browse repository at this point
Copy the full SHA ce10e43View commit details -
Configuration menu - View commit details
-
Copy full SHA for e084e3b - Browse repository at this point
Copy the full SHA e084e3bView commit details
Commits on Nov 3, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 679c839 - Browse repository at this point
Copy the full SHA 679c839View commit details