Optimise LoadNexusProcessed for multiperiod data #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`openLocal` performs far better than open, and we're able to use it when loading multidimensional data sets in LoadNexusesProcessed, so let's.
eXeC64
added
Reflectometry
|
Could you please add some comments around the code relating to the fix. Although I understand what's been done here, it would be good if others had that opportunity too. |
OwenArnold
added a commit
that referenced
this pull request
Apr 10, 2015
…c_performance Optimise LoadNexusProcessed for multiperiod data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for trac ticket #11505
This pull request improved the load time of
INTER00027729.nxsfrom ~745 seconds down to ~84 seconds on my machine.Tester: The most important thing to check here is that the changes do not corrupt the data in some way whilst loading it. I've done some comparisons myself that I'll detail below. If data loading has been damaged in some way by this, it's highly likely that a systemtest will be broken, so don't presume they're random failures.
The first comparison I did was by running two instances of Mantid side by side, one with and one without the changes. In each I loaded
INTER00027729.nxsand manually compared random samples of the data. I found no differences.The second comparison I did was run the code from the
OFFSPECReflRedOneAutosystem test in a unchanged Mantid, and save a single period of the result to disk. I then loaded the changed Mantid, and ran the same systemtest code. I then loaded the saved result and usedCheckWorkspacesMatchto check they were identical, which they were.