Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ipython notebook dependencies in OS X bundle. #606

Merged
merged 1 commit into from Apr 17, 2015

Conversation

quantumsteve
Copy link
Contributor

This fixes #11482

A user complained that the 10.9 package isn't allowing him to use the ipython notebook. We've tracked this down to a packaging fault. This pull request should fix this issue and make it more difficult for them to occur in the future.

Our current bundle should not require setting the DYLD_LIBRARY_PATH environment variable as described on the wiki. That being said, it also shouldn't hurt anything and I'm hesitant to update the documentation until after release 3.4.

Testing

  • Try generating an OS X bundle after uninstalling one of the python libraries.Verify that the packaging step exits with a fatal error.
  • Build an OS X bundle and install it. Verify that ipython notebook is functioning.

@quantumsteve quantumsteve added Python Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) labels Apr 16, 2015
@quantumsteve quantumsteve added this to the Release 3.4 milestone Apr 16, 2015
@OwenArnold
Copy link
Contributor

@quantumsteve I can start the IPython Notebook, however I would not be able to use this with Mantid. If I modify the DYLD_LIBRARY_PATH as per our existing instructions, I get this:

screen shot 2015-04-17 at 08 59 43

We need to be able to load the plugins and core mantid libraries so that we can use them with the notebook, but clearly dragging in the libJPeg is a mistake in this case.

@quantumsteve
Copy link
Contributor Author

@OwenArnold If you unset your DYLD_LIBRARY_PATH, can you then load the Mantid libraries?

hdf4 depends on libjpeg, which is installed by homebrew. Setting your DYLD_LIBRARY_PATH causes some system libraries to find this libjpeg instead of the system library.

@OwenArnold
Copy link
Contributor

@quantumsteve. Yes it does work now without any need to modify the library paths. Could you please update the wiki documentation so that there is a 10.9+ section (or do it by Mantid version) in the OSX heading. We can remove the current instructions for OSX when the release is out.

OwenArnold added a commit that referenced this pull request Apr 17, 2015
Include ipython notebook dependencies in OS X  bundle.
@OwenArnold OwenArnold merged commit 7a49f41 into master Apr 17, 2015
@OwenArnold OwenArnold deleted the 11482_ipython_notebook branch April 17, 2015 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants