Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory "leak" when retrieving history from Python #614

Merged
merged 3 commits into from Apr 21, 2015
Merged

Fix memory "leak" when retrieving history from Python #614

merged 3 commits into from Apr 21, 2015

Conversation

martyngigg
Copy link
Member

Fixes issue #11589

Tester
The ticket describes how to reproduce the issue. It is best to convince yourself that you understand the problem before merging the fix so you can be sure the fix does what it describes.

@martyngigg
Use an unmanaged algorithm when creating from a string
4951444 
There is no reason the algorithm should be retained in the manager.
Refs #11589
@martyngigg martyngigg added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework labels Apr 20, 2015
@martyngigg martyngigg added this to the Release 3.4 milestone Apr 20, 2015
@martyngigg
Fix expected error string
8ca545a 
The message is now just what comes out for the factory
Refs #11589
@martyngigg
Fix crash in SANS reduction.
6690810 
Python doesn't seem to guarantee that the shared_ptr will survive
during a chained method call. This is poor coding practice
anyway...
Refs #11589
@NickDraper NickDraper self-assigned this Apr 21, 2015
@NickDraper
Copy link
Contributor

verified as fixed on windows 7

NickDraper added a commit that referenced this pull request Apr 21, 2015
@NickDraper
Merge pull request #614 from mantidproject/11589_memory_lost_on_get_h…
4434327 
…istory

Fix memory "leak" when retrieving history from Python
@NickDraper NickDraper merged commit 4434327 into master Apr 21, 2015
@NickDraper NickDraper deleted the 11589_memory_lost_on_get_history branch April 21, 2015 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@NickDraper NickDraper

Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Milestone
Release 3.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martyngigg @NickDraper