Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask detectors in POLDI data automatically #629

Merged
merged 3 commits into from Apr 23, 2015

Conversation

MichaelWedel
Copy link
Contributor

This addresses #11607.

PoldiLoadRuns now optionally (it's the new default behavior) excludes detectors that deviate too much (most often because of gamma background) from the rest. It's essentially an additional call to MedianDetectorTest. The change is documented in the algorithm documentation.

Testing information
Code review. You could run the following script with varying parameters to see that the number of masked spectra changes (by using Color fill plot for example):

# Only the first 6 and the last 6 spectra are 0
idfMask = PoldiLoadRuns(2013, 6903, 6904, 2, MaskBadDetectors=False)

# Masking with default parameters excludes the very intense spectra around spectrum 320 and some others inbetween.
autoMask = PoldiLoadRuns(2013, 6903, 6904, 2)

# Setting the threshold higher leads to fewer detectors being masked
fewerMasked = PoldiLoadRuns(2013, 6903, 6904, 2, BadDetectorThreshold=5.0)

# The opposite happens for lower thresholds
moreMasked = PoldiLoadRuns(2013, 6903, 6904, 2, BadDetectorThreshold=1.5)

Michael Wedel added 3 commits April 21, 2015 18:06
Also added paragraph to documentation.
New default behavior of PoldiLoadRuns changes result in the last digit.
@MichaelWedel MichaelWedel added the Diffraction Issues and pull requests related to diffraction label Apr 22, 2015
@MichaelWedel MichaelWedel added this to the Release 3.4 milestone Apr 22, 2015
@FedeMPouzols FedeMPouzols self-assigned this Apr 23, 2015
@FedeMPouzols
Copy link
Contributor

All looks good and explained in the docs. Automated tests pass and from manual tests it seems to behave well, as I can see the increasing number of (masked) horizontal lines in the color plots.

FedeMPouzols added a commit that referenced this pull request Apr 23, 2015
…utomatically

Mask detectors in POLDI data automatically
@FedeMPouzols FedeMPouzols merged commit 79c33a0 into master Apr 23, 2015
@FedeMPouzols FedeMPouzols deleted the 11607_mask_poldi_spectra_automatically branch April 23, 2015 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants