Skip missing runs #645
Merged
Skip missing runs #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A unit test for this would be useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11624
To test: PlotAsymmetryByLogValue loads a set of runs given by the first run number and the last run number. Sometimes one of the runs in the set may be missing, but scientists would like to continue with the analysis. This is a simple fix and I think code review should be enough, but you can test this branch by running PlotAsymmetryByLogValue with "MUSR00015189.nxs" as "First run" and "MUSR00015193.nxs" as "Last Run". Before running the algorithm, move temporarily one of the other files (for instance MUSR00015191.nxs") to a different directory and check that a warning message indicating that the run was not found is shown.