Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean efixed parameters in indirect IPFs #658

Merged
merged 7 commits into from May 1, 2015

Conversation

DanNixon
Copy link
Member

Fixes #11638.

To test:

  • Open Indirect Data Reduction
  • Select any instrument configuration
  • See that the Efixed value is updated with the parameter from the correct IPF

The correct value will be the one in the [INSTRUMENT]_[ANALYSER][REFLECTION]_Parameters.xml file

@DanNixon DanNixon added Inelastic Indirect/Inelastic Issues and pull requests related to indirect or inelastic labels Apr 28, 2015
@DanNixon DanNixon added this to the Release 3.5 milestone Apr 28, 2015
@DanNixon DanNixon modified the milestones: Release 3.4, Release 3.5 Apr 30, 2015
@mantid-roman mantid-roman self-assigned this May 1, 2015
@mantid-roman
Copy link
Contributor

Which release is it?

@DanNixon
Copy link
Member Author

DanNixon commented May 1, 2015

3.4 now as if it was left to 3.5 this would break UIs as the IPFs would be out of sync with the code.

mantid-roman added a commit that referenced this pull request May 1, 2015
@mantid-roman mantid-roman merged commit 5e3ce44 into master May 1, 2015
@mantid-roman mantid-roman deleted the 11638_clean_efixed_parameters branch May 1, 2015 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants