Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new SofQW workflow algorithm in IDR tab #659

Merged
merged 1 commit into from Apr 29, 2015
Merged

Use the new SofQW workflow algorithm in IDR tab #659

merged 1 commit into from Apr 29, 2015

Conversation

DanNixon
Copy link
Member

Fixes #11640.

To test:

  • Open IDR > SQw
  • Load irs26176_graphite002_red.nxs
  • Q binning: 0.6, 0.1, 1.8
  • Energy binning: -0.6, 0.01, 0.6
  • Plot contour
  • Run

Try with both rebin types and check that the correct algorithm was run: Parallelepiped should run SofQWPolygon, Parallelepiped/Fractional Area should run SofQWNormalisedPolygon.

@DanNixon DanNixon added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Inelastic Indirect/Inelastic Issues and pull requests related to indirect or inelastic labels Apr 28, 2015
@DanNixon DanNixon added this to the Release 3.4 milestone Apr 28, 2015
@FedeMPouzols FedeMPouzols self-assigned this Apr 29, 2015
@FedeMPouzols
Copy link
Contributor

Works well. In the algorithm history I can see SofQWPolygon and SofQWNormalisedPolygon.

To see it in the logs you need to go to debug level, I think, which is extremely verbose. Maybe an information/notice log message could be added about this? Not sure if that's common or recommended in workflow algorithms, but it could be helpful to users.

I just noticed an extremenly minor thing: the tab order of the E binning values seems a bit disordered.

FedeMPouzols added a commit that referenced this pull request Apr 29, 2015
@FedeMPouzols
Merge pull request #659 from mantidproject/11640_fix_idr_sqw
694558e 
Use the new SofQW workflow algorithm in IDR tab
@FedeMPouzols FedeMPouzols merged commit 694558e into master Apr 29, 2015
@FedeMPouzols FedeMPouzols deleted the 11640_fix_idr_sqw branch April 29, 2015 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@FedeMPouzols FedeMPouzols

Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Indirect/Inelastic Issues and pull requests related to indirect or inelastic
Projects
None yet
Milestone
Release 3.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DanNixon @FedeMPouzols