Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for 7 algorithms including usage examples #666

Merged
merged 6 commits into from May 1, 2015

Conversation

KarlPalmen
Copy link
Contributor

This pull request is about ticket #9726 which has 7 remaining algorithms, which needed usage examples and one (Stepscan) , which required a flowchart.

To test verify that the documentation has been improved and usage examples work. If any requires further work done that cannot be done quickly, please put it into a new ticket.

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>
Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>
Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>
Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>
@KarlPalmen KarlPalmen added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Documentation Issues and pull requests related to documentation labels Apr 28, 2015
@martyngigg martyngigg added this to the Release 3.4 milestone Apr 29, 2015
@martyngigg
Copy link
Member

@KarlPalmen It looks like there is a crash in the unit tests for ShowPeakHKLOffsets

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>
@@ -25,4 +25,29 @@ from an integer will have its (h,k,l) set to (0,0,0). The calculated
Miller indices can either be rounded to the nearest integer value, or
can be left as decimal fractions.

Usage
-----

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this also include:: ../usagedata-note.txt

@stuartcampbell stuartcampbell self-assigned this Apr 29, 2015
@KarlPalmen
Copy link
Contributor Author

I'm putting the usage data note in now.

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>
stuartcampbell added a commit that referenced this pull request May 1, 2015
Documentation for 7 algorithms including usage examples
@stuartcampbell stuartcampbell merged commit bf7f69a into master May 1, 2015
@stuartcampbell stuartcampbell deleted the 9726_documentation branch May 1, 2015 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues and pull requests related to documentation High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants