Respect qmin & qmax limits in new Reflectometry UI #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 30, 2015 08:40
If only qmin, or qmax is provided but the other isn't, we want to handle that correctly. Moving this logic out of the else clause does that.
eXeC64
added
Bug
FedeMPouzols
added a commit
that referenced
this pull request
May 20, 2015
…_new_refl_ui Respect qmin & qmax limits in new Reflectometry UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for trac ticket #11654
If a workspace is not stitched in the new Reflectometry UI, then the qmin/qmax limits are never applied. This pull request ensures that the limits are always applied.
Testing:
If you look at the resulting IvQ workspace, the range of x values should stay within qmin and qmax, applied by running Rebin.