Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems with Error Bars #691

Merged
merged 1 commit into from May 1, 2015
Merged

Problems with Error Bars #691

merged 1 commit into from May 1, 2015

Conversation

OwenArnold
Copy link
Contributor

See the original trac issue #11348 to see the detailed issue and full discussion surrounding the problem, as well as and the determination of the fix required.

Tester

  • Unit tests and system tests should pass. This is the most important thing to check.
  • If you have the computing power, you could also run the following and compare the result against the outputs recorded from the equivalent horace cuts in the ticket #11348. Ask me for the file if required.
from mantid.api import MDNormalization
data = Load("Fe_ei200.sqw")
cut = CutMD(data,NoPix=True,PBins=[[2.5,0.1,6],[-0.05,0.05],[-0.05,0.05],[56,64]])
plotMD(cut, normalization=MDNormalization.NumEventsNormalization)

@OwenArnold
refs #11348. Apply the fix.
ef19a20 
The algorithm documentation for this algorithm is actually up-to-date
correctly pointing out that the file stores the variance. The fix
brings the implementation in-line.
@OwenArnold OwenArnold added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Inelastic Vates labels Apr 30, 2015
@OwenArnold OwenArnold added this to the Release 3.4 milestone Apr 30, 2015
@martyngigg martyngigg self-assigned this Apr 30, 2015
martyngigg added a commit that referenced this pull request May 1, 2015
@martyngigg
Merge pull request #691 from mantidproject/11348_error_bars
b036f5c 
Problems with Error Bars
@martyngigg martyngigg merged commit b036f5c into master May 1, 2015
@martyngigg martyngigg deleted the 11348_error_bars branch May 1, 2015 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martyngigg martyngigg

Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Vates
Projects
None yet
Milestone
Release 3.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OwenArnold @martyngigg