Don't show pop-up in TomoReconstruction #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedeMPouzols
added
High Priority
| ". If you have set that facility by mistake in your settings, " | ||
| "please update it." << std::endl; | ||
| throw std::runtime_error( | ||
| "Failed to initialize because the facility is not " + fac.name()); |
There was a problem hiding this comment.
Should fac.name() not be m_facilty (or facility is not be facility is)?
Currently I get: Error description: Failed to initialize because the facility is not SNS
|
Oh yes, the message in that throw is wrong. I'm fixing it... |
DanNixon
added a commit
that referenced
this pull request
May 1, 2015
…reconstruction Don't show pop-up in TomoReconstruction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11675.
To test: set your facility to other than ISIS and see that you don't get a pop-up complaining about that, so you can also build the documentation (you might have to make a change to the RST to force a doc rebuild).