CanSAS reader should read in y-axis units #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdoucet
changed the title
|
This fixes #11689. Works well, after these changes the y units are shown if they are the same for all the data. Tested with the LOQ CanSAS file on debian. |
FedeMPouzols
added a commit
that referenced
this pull request
May 12, 2015
CanSAS reader should read in y-axis units
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test: load you favorite CanSAS file and make sure the units are loaded.
If you change the unit on one of the y-values so that they are not all the same, the loader should not set the y unit of the output workspace.