New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integrated monitor switch to ReflectometryReductionOne #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eXeC64
added
Reflectometry
Issues and pull requests related to reflectometry
In Progress
Framework
Issues and pull requests related to components in the Framework
labels
May 5, 2015
Looks like there was a recent change in master causing this to now fail AlgorithmsTest.ReflectometryReductionOneAutoTest. You may want to merge master into the branch to check. |
The syntax should be tested in the relevant algorithm's unit tests, not in the workflow algorithms.
The slight change in value is due to a difference in the way ConvertUnits and GroupDetectors are ordered in ReflectometryWorkflowBase.
FedeMPouzols
added a commit
that referenced
this pull request
Jun 12, 2015
…witch Add integrated monitor switch to ReflectometryReductionOne
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Framework
Issues and pull requests related to components in the Framework
Reflectometry
Issues and pull requests related to reflectometry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #12521
This pull request:
NormalizeByIntegratedDetectors
property toReflectometryReductionOne
andReflectometryReductionOneAuto
I0MonitorIndex