update our_run_code() for iPython 3+ #712
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11692.
The script interpreter is broken with iPython 3.0+.
This version adds a third optional argument named result that needed to be added to our_run_code(). The following changes attempt to call iPython_run_code() with three arguments. If that fails, it falls back to two arguments.
testing: Verify that one can run
import numpy
from the script interpreter. Ideally this should be tested with iPython < 3.0 and iPython >= 3.0