Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update our_run_code() for iPython 3+ #712

Merged
merged 3 commits into from May 5, 2015
Merged

Conversation

quantumsteve
Copy link
Contributor

This fixes #11692.

The script interpreter is broken with iPython 3.0+.

In [8]: import numpy
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
TypeError: our_run_code() takes exactly 2 arguments (3 given)

This version adds a third optional argument named result that needed to be added to our_run_code(). The following changes attempt to call iPython_run_code() with three arguments. If that fails, it falls back to two arguments.

testing: Verify that one can run import numpy from the script interpreter. Ideally this should be tested with iPython < 3.0 and iPython >= 3.0

@quantumsteve quantumsteve added Python Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) labels May 5, 2015
@quantumsteve quantumsteve added this to the Release 3.4 milestone May 5, 2015
@quantumsteve quantumsteve changed the title update our_run_code() for ipython 3+ update our_run_code() for iPython 3+ May 5, 2015
@peterfpeterson peterfpeterson self-assigned this May 5, 2015
peterfpeterson added a commit that referenced this pull request May 5, 2015
@peterfpeterson peterfpeterson merged commit a968db2 into master May 5, 2015
@peterfpeterson peterfpeterson deleted the 11692_ipython_3_fix branch May 5, 2015 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants