Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exported workspaces in ALC #725

Merged
merged 6 commits into from May 8, 2015
Merged

Conversation

raquelalvarezbanos
Copy link
Contributor

Fixes #11711

For tester:

  • Code review: make sure you understand the problem reported by scientists (see original trac issue and documentation) and the fix.
  • Reproduce the problem on the master branch: open ALC, load "MUSR00015189.nxs" as "First" and "MUSR00015193.nxs" as "Last", hit "Load", go to "Baseline Modelling", right-click on the "Function" blank region and add a LinearBackground, right-click on "Sections" blank section and add a section, hit "Fit", hit "Export results...", a WorkspaceGroup will be created. Right-click on "ALCResults_Baseline_Workspace" -> "Plot spectrum with errors" -> enter "0-1". Errors are huge for the "Baseline" curve.
  • On this branch, repeat the same steps. Check that errors in "Baseline" are reasonable.

@raquelalvarezbanos raquelalvarezbanos added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) In Progress Muon Issues and pull requests related to muons labels May 7, 2015
@raquelalvarezbanos raquelalvarezbanos added this to the Release 3.4 milestone May 7, 2015
@DanNixon DanNixon self-assigned this May 8, 2015
DanNixon added a commit that referenced this pull request May 8, 2015
@DanNixon DanNixon merged commit 18e57bd into master May 8, 2015
@DanNixon DanNixon deleted the 11711_Fix_exported_workspaces branch May 8, 2015 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Muon Issues and pull requests related to muons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants