Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sliceviewer axis swap issue #731

Merged
merged 4 commits into from May 12, 2015

Conversation

eXeC64
Copy link
Contributor

@eXeC64 eXeC64 commented May 11, 2015

This is for trac ticket #11710

If the axes of a plot are transposed, any existing plots update fine, with the exception of the axis labels. This pull request ensures that axis labels are recalculated so that they're always accurate.

This has been marked as CORE because it significantly affects the way axis labels of MantidPlot plots are set. Behaviour should not visibly change except for the one known issue: When a plot's curves are edited, then the axis labels are recalculated and any changes the user may have made to the labels are discarded. This is unavoidable as QwtPlot does not allow interception of user modifications to the axis labels, or notifications that it has happened.

Testing:

  1. View a multidimensional workspace
  2. Create a line cut
  3. plot the resulting line in mantidplot and keep the plot open
  4. Now switch the axis in the sliceviewer
  5. You can continue to draw the lines and the plots update, but the x/y labels of the plots should be updated, but don't get redrawn.
CreateMDWorkspace(Dimensions='3', Extents='-10,10,-10,10,-10,10', Names='A,B,C', Units='U,U,U', OutputWorkspace='ws')
FakeMDEventData(InputWorkspace='ws', UniformParams='10000')

Harry Jeffery added 4 commits May 7, 2015 16:31
There's insufficient information available to figure out what the axes
should be when updating the axes text, it can only be done from its
existing location. The positibility of an axis transposition bug in this
context is remote, so we're leaving it in place.
@eXeC64 eXeC64 added MantidPlot Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Extra Attention Testers and Gate keepers should pay extra attention as this affects core aspects. labels May 11, 2015
@eXeC64 eXeC64 added this to the Release 3.4 milestone May 11, 2015
@Anders-Markvardsen Anders-Markvardsen self-assigned this May 12, 2015
Anders-Markvardsen added a commit that referenced this pull request May 12, 2015
@Anders-Markvardsen Anders-Markvardsen merged commit 1501dd9 into master May 12, 2015
@Anders-Markvardsen Anders-Markvardsen deleted the 11710_sliceviewer_axis_swap_issue branch May 12, 2015 09:17
@Anders-Markvardsen
Copy link
Member

Worked with attached script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Extra Attention Testers and Gate keepers should pay extra attention as this affects core aspects.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants