Change the range in the color map editor => update selection widget min/max line edits #746
Conversation
|
I'm going to see if we can also keep the checkbox "auto color scaling" in sync with the Paraview map editor. That should be coming in a next commit a bit later today... |
|
I think the "auto color scaling" check box behaves well now (in sync with the Paraview color map editor). But maybe we should still have a chat. Now that the VSI simple ColorSelectionWidget is updated by the ParaQ color map values, it turns out that we get different color ranges when switching between views. My first guess would be that we still want to enforce the default VSI auto-scale initially on all the views? Or is it better to use the scale that the ParaQ color editor produces by default? I also noticed another oddity. This is in "use log" tick boxes. They are connected "left to right" but not "right to left". This could be easy to fix, if only I could find what vtk property is involved in that log scale check box. |
|
Aha, I think I can have the log-scale issue fixed a bit later today still in time for tonight's build. |
|
Can I start testing? |
…_link_color_map_editor_to_color_selection_widget_lineedits bring in the 'keep status when switching between vsi views'
|
I think this should be ready now. The last commits should have:
About the second point we still have a glitch when you switch to the multislice view. You'll often lose the auto-scale state, so the user needs to click again on 'auto scale' if it wants the default vsi auto range instead of the Paraview range. If I don't find a very last minute solution for this, it will have to be a new ticket to sort out later. |
|
The windows failure is an unrelated issue of one of the CI machines. |
|
Windows build on my PC is fine |
|
Interaction seems a great improvement to me. This alters some of the same classes as the change Anton has just put in. Do we want to check they work nicely together? |
|
I'm going to merge the latest master and see if everything is still fine. |
…_link_color_map_editor_to_color_selection_widget_lineedits
|
On windows it looks good, but this needs a check on Mac as we saw some ealier behaviour that was suspicious (max and min value not being updated) |
…to_color_selection_widget_lineedits Conflicts: Code/Mantid/Vates/VatesSimpleGui/ViewWidgets/src/MdViewerWidget.cpp Sort out merge conflict from when we moved setBackgroundColor to the bottom of switchViews, re #11706
|
There's a merge conflict currently. |
…_link_color_map_editor_to_color_selection_widget_lineedits Conflicts: Code/Mantid/Vates/VatesSimpleGui/ViewWidgets/src/ViewBase.cpp spurious conflict in principle, re #11706
…olor_map_editor_to_color_selection_widget_lineedits Change the range in the color map editor => update selection widget min/max line edits
OwenArnold
deleted the
11706_color_map_vsi_link_color_map_editor_to_color_selection_widget_lineedits
branch
This fixes #12544 The VSI selection widget should react properly when you change the range of the color scale in the Paraview "color map editor". This is done here with a Vtk callback on the RGBPoints property of the Vtk proxy for the color lookup table of the color editor.
To test:
Release notes: See here http://www.mantidproject.org/ReleaseNotes_3_5_UI_Changes, in "3D Visualisation (VSI)".