alloc-dealloc-mismatch in vtkDataSetToNonOrthogonalDataSetTest #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantumsteve
added
Bug
FedeMPouzols
added a commit
that referenced
this pull request
May 21, 2015
alloc-dealloc-mismatch in vtkDataSetToNonOrthogonalDataSetTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11762.
AddressSanitizer found an alloc-dealloc-mismatch in vtkDataSetToNonOrthogonalDataSetTest. The full error is in the ticket. Instead of fixing the delete, I replaced owning raw pointer with std::vector. Given the size of the array (16 elements) the extra copy is very fast and probably eliminated by return value optimization.
testing: Given the size of the change, code review is sufficient.