New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New ISIS indirect diffraction reduction algorithm #763
New ISIS indirect diffraction reduction algorithm #763
Conversation
Gets identical results for IRIS reductions (at least usng as much as has been implemented so far) Refs #10855
Need to add saving Refs #10855
…_reduction Conflicts: Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/IndirectDiffractionReduction.cpp Refs #10855
…_reduction Conflicts: Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/MSGDiffractionReduction.py Code/Mantid/scripts/Inelastic/IndirectDiffractionReduction.py Refs #10855
…_reduction Conflicts: Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/MSGDiffractionReduction.py Refs #10855
Did not account for VESUVIO on diffraction. |
…_reduction Conflicts: Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/ISISIndirectEnergyTransfer.py Refs #10855
All looks fine and the documentation makes perfect sense. But pylint has a different opinion... IndirectReductionCommon.py comes with 42 warnings: http://builds.mantidproject.org/job/pull_requests-pylint/439/violations/file/IndirectReductionCommon.py/, and ISISIndirectDiffractionReduction.py introduces 15. Some of them make sense and seem esay to fix (like an unused import). Then there is also the annoying issue with mantid.simpleapi where |
I'm assuming Considering I do this in pretty much every Python algorithm I write (as do a fair few other developers) this should just be ignored globally. |
The only (spurious) issue is the failed windows doc-test. I passed them locally and it went fine. The doc-test issues are totally unrelated to this PR. |
…rect_diffraction_reduction New ISIS indirect diffraction reduction algorithm
Fixes #10855.
To test: