Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change IDF name mangling to use SHA1 rather than last modified date #776

Merged
merged 4 commits into from May 28, 2015

Conversation

NickDraper
Copy link
Contributor

http://trac.mantidproject.org/mantid/ticket/11569

To test

  1. Start with a code review, and ensure that all unit and system tests pass
  2. Manually load a RAW file (use Load, not LoadEmptyInstrument).
  3. Look to see where the instrument file was loaded from by dropping down the details of the workspace.
    image
  4. Go into the instrument directory and make a visible change (like move a bank vertically). Do not change the last-modified date.
  5. without closing mantid, reload the same file into a different workspace.
  6. look at the instrument views of both workspaces, check the 2nd one got the updated image.
  7. MAKE SURE YOU DO NOT COMMIT THE CHANGE TO THE IDF.

@NickDraper NickDraper added In Progress Framework Issues and pull requests related to components in the Framework labels May 20, 2015
@NickDraper NickDraper added this to the Release 3.5 milestone May 20, 2015
@NickDraper NickDraper changed the title re #11569 change date to checksum Change IDF name mangling to use SHA1 rather than last modified date May 20, 2015
@NickDraper
Copy link
Contributor Author

This is a purely internal issue, there is no need to contain details about this in the release notes.

@KarlPalmen KarlPalmen self-assigned this May 21, 2015
@KarlPalmen
Copy link
Contributor

Test failed on LET instrument. Instrument view is unchanged even if a door is removed.

The only difference I noticed was that if the instrument definition file is updated, it took just as long to load as it did first time, but if the file is not updated loading is quicker.

@NickDraper
Copy link
Contributor Author

I think the problem was that the test was run with a nexus file with an embedded xml definition.

This is a known problem I'm fixing in #11818.

Could you try again with a raw file.

@KarlPalmen
Copy link
Contributor

Yes the file is used to test this does have an embedded xml definition.

@KarlPalmen
Copy link
Contributor

I've tested again with a Nexus file without embedded IDF and a raw file. I both cases, I saw part of the instrument move when loading after modifying the IDF file as described.

KarlPalmen added a commit that referenced this pull request May 28, 2015
…ksum_in_name_mangling

Change IDF name mangling to use SHA1 rather than last modified date
@KarlPalmen KarlPalmen merged commit 612f3b5 into master May 28, 2015
@KarlPalmen KarlPalmen deleted the feature/11569_IDF_use_checksum_in_name_mangling branch May 28, 2015 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants