Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LINK_PRIVATE where possible in CMake #779

Merged
merged 12 commits into from May 21, 2015
Merged

Add LINK_PRIVATE where possible in CMake #779

merged 12 commits into from May 21, 2015

Conversation

mantid-roman
Copy link
Contributor

Ticket #11756

@mantid-roman mantid-roman added In Progress Maintenance Unassigned issues to be addressed in the next maintenance period. labels May 20, 2015
@mantid-roman mantid-roman added this to the Release 3.5 milestone May 20, 2015
@eXeC64 eXeC64 self-assigned this May 21, 2015
@eXeC64
Copy link
Contributor

eXeC64 commented May 21, 2015

  • Full clean build works
  • Linking time has improved a bit:
    • Measured with: ninja -j8; rm bin/*.so; time ninja -j8
    • Before: 66.18s user 4.12s system 512% cpu 13.708 total
    • After: 51.24s user 3.79s system 541% cpu 10.168 total
  • The resulting binaries have not changed in size

eXeC64 added a commit that referenced this pull request May 21, 2015
@eXeC64
Merge pull request #779 from mantidproject/11756_add_link_private_to_…
01814ae 
…cmakelists

Add LINK_PRIVATE where possible in CMake
@eXeC64 eXeC64 merged commit 01814ae into master May 21, 2015
@eXeC64 eXeC64 deleted the 11756_add_link_private_to_cmakelists branch May 21, 2015 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eXeC64 eXeC64

Labels
Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Milestone
Release 3.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mantid-roman @eXeC64