Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set recursion depth for top level split to 1 #781

Merged

Conversation

AntonPiccardoSelg
Copy link
Contributor

Original ticket here

For testing:
You can find the necessary python script here

You need the data set SXD23767.nxs which can be found in the trainging pack.
Run the script. This should produce the workspaces Split and No_Split.

Test for workspace with top level splitting

  1. Open the data set Split into the VSI.
    • Confirm that the recursion depth entry of the source shows 1
    • Confirm that the recursion depth is actually 1. Change it to 5 - you should see a difference (finer granularity)

Test for workspace without top level splitting

  1. Open the data set No_Split into the VSI.
    • Confirm that the recursion depth entry of the source shows 5
    • Confirm that the recursion depth is actually 5. Change it to 1 - you should see a difference (coarser granularity).

@OwenArnold
Copy link
Contributor

Could you please add something to the release notes about these changes. Probably to bug fixes http://www.mantidproject.org/ReleaseNotes_3_5_UI_Changes

@AntonPiccardoSelg
Copy link
Contributor Author

Added information regarding these changes to the release notes

@OwenArnold
Copy link
Contributor

Functionally correct. Some refactoring changes proposed.

@AntonPiccardoSelg
Copy link
Contributor Author

Refactored the check for top level splitting. The refactored function is directly called from within MDEWSource and ViewBase. In the former case we are not going through the presenter, as this is a generic interface for both MDEvent- and MDHisto-based sources, whereas the recursion depth is only applicable for MDEvent-based sources.

@AntonPiccardoSelg
Copy link
Contributor Author

  • Changed the include guards
  • Changed the unit test for MDEvent data with top level splitting

@AntonPiccardoSelg
Copy link
Contributor Author

RHEL6 build issue seems to be a gcc4 issue

OwenArnold added a commit that referenced this pull request Jun 1, 2015
…n_depth_for_top_level_split_to_1

Set recursion depth for top level split to 1
@OwenArnold OwenArnold merged commit 1216797 into master Jun 1, 2015
@OwenArnold OwenArnold deleted the feature/11814_set_recursion_depth_for_top_level_split_to_1 branch June 1, 2015 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants