Coverity issues: Muon and NeXus load issues #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedeMPouzols
added
Maintenance
| @@ -77,16 +77,16 @@ class DLLExport AppendGeometryToSNSNexus : public API::Algorithm { | |||
| bool m_makeNexusCopy; | |||
|
|
|||
| /// Algorithm progress keeper | |||
| API::Progress *progress; | |||
| API::Progress *m_progress; | |||
|
|
|||
There was a problem hiding this comment.
With this m_progress I think we have the same issue as I've seen in other algorithms. Somewhere in the implementation it is allocated with new but then never deleted. This is just a small leak but it could be fixed here, simply adding the missing delete or, most likely better, by using a smart pointer. Oh, and also progress/m_progess does not need to be a member of the class, it can live just inside the exec method().
|
We got failures in the |
FedeMPouzols
added a commit
that referenced
this pull request
May 28, 2015
Coverity issues: Muon and NeXus load issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11825
For tester: code review, check that all the issues reported in the trac ticket have been solved.